[Patches] [PATCH] Bug 7345: Enable exporting records sans private fields
koha-patchbot at kohaaloha.com
koha-patchbot at kohaaloha.com
Tue Dec 13 22:06:06 NZDT 2011
From: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat, 10 Dec 2011 20:14:52 -0500
Subject: [PATCH] Bug 7345: Enable exporting records sans private fields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Add an option for marcstd to the opac-export.pl and catalogue/export.pl
scripts. This new format removes all 9XX, X9X, XX9 fields and subfield $9
(with the exception of 490 in flavours of MARC other than UNIMARC). The work is
done in C4::Record::marc2marc.
Testing plan:
1. Export a record in "MARC (Unicode/UTF-8)" format as a control
2. In the OPAC, run the following jQuery to add the marcstd option to the UI:
> $("#export #format").append("<option value='marcstd'>MARC (no 9xx)</option>");
3. Export the same record in "MARC (no 9xx)" format
4. Compare the two, noticing that any subfield $9 or fields including 9 (other
than 490 in flavours of MARC other than UNIMARC) have been removed
Signed-off-by: Frère Sébastien Marie <semarie-koha at latrappe.fr>
Test done under UNIMARC flavour. All seems to work well.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Test done under MARC21 flavour, works fine.
---
C4/Record.pm | 27 ++++++++++++++++++++++++++-
catalogue/export.pl | 4 ++++
opac/opac-export.pl | 4 ++++
3 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/C4/Record.pm b/C4/Record.pm
index cecb6ed..9c55abb 100644
--- a/C4/Record.pm
+++ b/C4/Record.pm
@@ -77,7 +77,32 @@ Returns an ISO-2709 scalar
sub marc2marc {
my ($marc,$to_flavour,$from_flavour,$encoding) = @_;
- my $error = "Feature not yet implemented\n";
+ my $error;
+ if ($to_flavour =~ m/marcstd/) {
+ my $marc_record_obj;
+ if ($marc =~ /^MARC::Record/) { # it's already a MARC::Record object
+ $marc_record_obj = $marc;
+ } else { # it's not a MARC::Record object, make it one
+ eval { $marc_record_obj = MARC::Record->new_from_usmarc($marc) }; # handle exceptions
+
+# conversion to MARC::Record object failed, populate $error
+ if ($@) { $error .="\nCreation of MARC::Record object failed: ".$MARC::File::ERROR };
+ }
+ unless ($error) {
+ my @privatefields;
+ foreach my $field ($marc_record_obj->fields()) {
+ if ($field->tag() =~ m/9/ && ($field->tag() != '490' || C4::Context->preference("marcflavour") eq 'UNIMARC')) {
+ push @privatefields, $field;
+ } elsif (! ($field->is_control_field())) {
+ $field->delete_subfield(code => '9') if ($field->subfield('9'));
+ }
+ }
+ $marc_record_obj->delete_field(@privatefields);
+ $marc = $marc_record_obj->as_usmarc();
+ }
+ } else {
+ $error = "Feature not yet implemented\n";
+ }
return ($error,$marc);
}
diff --git a/catalogue/export.pl b/catalogue/export.pl
index 2b55d9f..db69af9 100755
--- a/catalogue/export.pl
+++ b/catalogue/export.pl
@@ -51,6 +51,10 @@ if ($op eq "export") {
C4::Charset::SetUTF8Flag($marc, 1);
$marc = $marc->as_usmarc();
}
+ elsif ($format =~ /marcstd/) {
+ C4::Charset::SetUTF8Flag($marc,1);
+ ($error,$marc) = marc2marc($marc, 'marcstd', C4::Context->preference('marcflavour'));
+ }
print $query->header(
-type => 'application/octet-stream',
-attachment=>"bib-$biblionumber.$format");
diff --git a/opac/opac-export.pl b/opac/opac-export.pl
index 411fd3f..fb8dee7 100755
--- a/opac/opac-export.pl
+++ b/opac/opac-export.pl
@@ -66,6 +66,10 @@ elsif ($format =~ /utf8/) {
C4::Charset::SetUTF8Flag($marc,1);
$marc = $marc->as_usmarc();
}
+elsif ($format =~ /marcstd/) {
+ C4::Charset::SetUTF8Flag($marc,1);
+ ($error,$marc) = marc2marc($marc, 'marcstd', C4::Context->preference('marcflavour'));
+}
else {
$error= "Format $format is not supported.";
}
--
1.7.5.4
More information about the Patches
mailing list