[Patches] [PATCH] [SIGNED-OFF] Bug 7249: added saved_sql fields to

[koha-patchbot at kohaaloha.com]

From: Chris Hall <chrish at catalyst.net.nz>
Date: Tue, 29 Nov 2011 10:21:44 +1300
Subject: [PATCH] [SIGNED-OFF] Bug 7249: added saved_sql fields to
 kohastructure

http://bugs.koha-community.org/show_bug.cgi?id=7249
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Patches applied on top of patches for bug 7248.
Patch includes another database adding 2 new fields to the saved_sql table.

1) Checked that adding/deleting/editing of sql reports still works and new
fields are correctly saved to the database.

2) The saved reports page now lists the new fields correctly.

3) Checking URLs with JSON output
- if report is not public http://localhost/cgi-bin/koha/svc/report?id=2 fails,
but http://localhost:8080/cgi-bin/koha/svc/report?id=2 works
- if report is public, both links work

4) Checking results are cached
Created a report listing my borrowers, setting caching to 60 seconds and
added new borrowers before doing following tests.
- URL doesn't show new borrower immediately - correct
- Turning off the usecache system preference updates data - correct
- Restarting memcached updates data '/etc/init.d/memcached restart' - correct
- Waiting until cache time runs out updates data - correct

Small enhancement request: Use yes/no instead of true/false.
---
 installer/data/mysql/kohastructure.sql |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
index a03bd23..cecc364 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -1626,6 +1626,8 @@ CREATE TABLE saved_sql (
    `report_name` varchar(255) default NULL,
    `type` varchar(255) default NULL,
    `notes` text,
+   `cache_expiry` int NOT NULL default 300,
+   `public` boolean NOT NULL default FALSE, 
    PRIMARY KEY  (`id`),
    KEY boridx (`borrowernumber`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
-- 
1.7.5.4