[Patches] [PATCH] Bug 6098 Followup -- doesn't replace NSB/NSE by space

koha-patchbot at kohaaloha.com koha-patchbot at kohaaloha.com
Thu Dec 22 08:20:04 NZDT 2011


From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians at tamil.fr>
Date: Fri, 13 May 2011 15:24:39 +0200
Subject: [PATCH] Bug 6098 Followup -- doesn't replace NSB/NSE by space
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a
good thing:

  - It isn't necessary since Zebra indexer handle properly those characters as
    delimiter.
  - It isn't necessary for display since XSL file already do that.
  - It isn't efficient since a regex is done on every whole page sent by Koha,
    not only on biblio record part.
  - It removes an information that librarian want to keep in their biblio
    records: any record edited in Koha loose its NSB/NSE characters.

Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
---
 C4/Output.pm |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/C4/Output.pm b/C4/Output.pm
index 6ab16d9..75ced46 100644
--- a/C4/Output.pm
+++ b/C4/Output.pm
@@ -291,10 +291,7 @@ sub output_with_http_headers($$$$;$) {
         $options->{'Content-Style-Type' } = 'text/css';
         $options->{'Content-Script-Type'} = 'text/javascript';
     }
-    # remove SUDOC specific NSB NSE
-    $data =~ s/\x{C2}\x{98}|\x{C2}\x{9C}/ /g;
-    $data =~ s/\x{C2}\x{88}|\x{C2}\x{89}/ /g;
-      
+
 # We can't encode here, that will double encode our templates, and xslt
 # We need to fix the encoding as it comes out of the database, or when we pass the variables to templates
  
-- 
1.7.5.4


More information about the Patches mailing list