[Patches] [PATCH] Bug 7375 - Update minimum version of Perl to 5.10

koha-patchbot at kohaaloha.com koha-patchbot at kohaaloha.com
Fri Dec 23 08:25:03 NZDT 2011


From: Magnus Enger <magnus at enger.priv.no>
Date: Thu, 22 Dec 2011 10:20:44 +0100
Subject: [PATCH] Bug 7375 - Update minimum version of Perl to 5.10

- Change the installer script to look for at least 5.10/5.010000
- Change the template to ask for the correct version

To test:
- Run through the webinstaller on 5.10 or newer and check that there are
no errors.
- Ideally: Run through the webinstaller on an older version than 5.10 and
check that there *is* an error, asking for 5.10 or newer.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
---
 installer/install.pl                               |    2 +-
 .../prog/en/modules/installer/step1.tt             |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/installer/install.pl b/installer/install.pl
index ae478b6..1619f50 100755
--- a/installer/install.pl
+++ b/installer/install.pl
@@ -59,7 +59,7 @@ if ( $step && $step == 1 ) {
     $template->param( language => 1 );
     $template->param( 'checkmodule' => 1 ); # we start with the assumption that there are no problems and set this to 0 if there are
 
-    unless ( $] >= 5.008008 ) {    # Bug 4505
+    unless ( $] >= 5.010000 ) {    # Bug 7375
         $template->param( problems => 1, perlversion => 1, checkmodule => 0 );
     }
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
index dbc3736..52c52c6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt
@@ -49,8 +49,8 @@ listed, please inform your systems administrator.</p>
   <p>I encountered some problems.</p>
    <ul>
     [% IF ( perlversion ) %]
-    <li>Your perl version seems to be obsolete.
-      Please upgrade to a newer version of Perl (at least Version 5.006001).</li>
+    <li>Your Perl version seems to be obsolete.
+      Please upgrade to a newer version of Perl (at least Version 5.10).</li>
     [% END %]
    </ul>
   [% END %]
-- 
1.7.5.4


More information about the Patches mailing list