[Patches] [PATCH] [SIGN-OFF]Bug 5995 Follow up: variable scope in

[koha-patchbot at kohaaloha.com]

From: Ian Walls <ian.walls at bywatersolutions.com>
Date: Tue, 18 Oct 2011 10:18:14 -0400
Subject: [PATCH] [SIGN-OFF]Bug 5995 Follow up: variable scope in
 koha/sco/sco-main.pl

The patronid value (cardnumber) set by checkpw in the case of SelfCheckoutByLogin
was improperly scoped with 'my' inside a conditional.  The changes followup to 5995
made this more apparent, causing logins to fail.

Also added "parts copyright" statement to the script, since ByWater Solutions did make some
significant contributions to the operations of the page

Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
---
 opac/sco/sco-main.pl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl
index 2488f67..416f136 100755
--- a/opac/sco/sco-main.pl
+++ b/opac/sco/sco-main.pl
@@ -2,6 +2,7 @@
 #
 # This code has been modified by Trendsetters (originally from opac-user.pl)
 # This code has been modified by rch
+# Parts Copyright 2010-2011, ByWater Solutions (those related to username/password auth)
 # We're going to authenticate a self-check user.  we'll add a flag to borrowers 'selfcheck'
 #
 # We're in a controlled environment; we trust the user.
@@ -92,7 +93,7 @@ my $issuer   = GetMemberDetails($issuerid);
 my $item     = GetItem(undef,$barcode);
 if (C4::Context->preference('SelfCheckoutByLogin') && !$patronid) {
     my $dbh = C4::Context->dbh;
-    my ($resval, $patronid) = checkpw($dbh, $patronlogin, $patronpw);
+    (my $resval, $patronid) = checkpw($dbh, $patronlogin, $patronpw);
 }
 my $borrower = GetMemberDetails(undef,$patronid);
 
-- 
1.7.5.4